[Piglit] [PATCH 5/6] generators: Replace outerProduct-invalid-paramters.sh with python

Kenneth Graunke kenneth at whitecape.org
Fri May 9 15:46:25 PDT 2014

On 05/09/2014 01:21 PM, Dylan Baker wrote:
> This Adds a new python generator to replace the shell generator. The old
> generator was run once and the results were checked into git, the python
> generator on the other hand is run at build time.
> The tests are equivalent with only whitespace differences.
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>

I verified that these tests are equivalent, aside from whitespace changes.

Patches 1-3 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Patch 5 is:
Acked-by: Kenneth Graunke <kenneth at whitecape.org>

Patch 6 seems to have gotten stuck in the moderation queue, but I
grabbed your branch and looked at it.  There is a typo:

-# glUniformMatrix4x2fv only exists in OpenGL 2.1 or later.
+# glUniformMatrix4x2fv only exits in OpenGL 2.1 or later

"exits" vs "exists", and the trailing period.  Also, it would be nice to
preserve the space after "probe" and before the next set of "uniform"
calls...but not a big deal.

With the typos fixed, patch 6 is:
Acked-by: Kenneth Graunke <kenneth at whitecape.org>

Thanks for doing this!  It's really nice to not have all this generated
stuff in revision control.  And, using Python for this is a lot nicer
than Bash.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140509/b5ad158b/attachment.sig>

More information about the Piglit mailing list