[Piglit] [PATCH] ext_framebuffer_multisample: Add testing for fast clear color path
chrisf at ijw.co.nz
Fri May 9 18:13:15 PDT 2014
I'd have also probably reported the two test results separely as subtests.
Either way, this is:
Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
On Sat, May 10, 2014 at 7:09 AM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
> On Thu, May 8, 2014 at 5:12 PM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
>> On Thu, May 8, 2014 at 3:33 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:
>>> On Fri, May 9, 2014 at 10:13 AM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
>>>> + /* Test with color values compatible with 'fast clear'. It varifies
>>> It might be worth noting that this is meeting *i965's* fast clear
>>> constraints. Other hardware will have "fast clear" paths with
>>> different constraints.
>> Right. I'll bump up the comment.
> With the bumped up comment, should I consider this r-b you?
More information about the Piglit