[Piglit] [PATCH 03/15] arb_occlusion_query: use default window size

Jose Fonseca jfonseca at vmware.com
Wed May 14 21:43:45 PDT 2014



----- Original Message -----
> On 14.05.2014 10:06, Brian Paul wrote:
> > 
> > diff --git a/tests/spec/arb_occlusion_query/occlusion_query.c
> > b/tests/spec/arb_occlusion_query/occlusion_query.c
> > index e099f06..b8ea664 100644
> > --- a/tests/spec/arb_occlusion_query/occlusion_query.c
> > +++ b/tests/spec/arb_occlusion_query/occlusion_query.c
> > @@ -34,9 +34,6 @@
> >  PIGLIT_GL_TEST_CONFIG_BEGIN
> >  
> >          config.supports_gl_compat_version = 10;
> > -
> > -        config.window_width = 180;
> > -        config.window_height = 100;
> 
> This change breaks the test for me, because the window is no longer wide
> enough to contain everything rendered by the test.

I suppose that the 180x100 is too small for Windows. But the Linux default window size is too small for the test.

Instead of making all these testes using default size (which I believe to be tiny on Linux), maybe change the intepretation of config.window_width/height so that they indicate the minimum window size?

Jose


> 
> 
> The spec/NV_conditional_render/clear test was also broken for me by the
> corresponding change, but there it's not obvious to me whether it's a
> test or driver bug.
> 
> 
> How are you testing changes like these?
> 
> 
> --
> Earthling Michel Dänzer            |
> https://urldefense.proofpoint.com/v1/url?u=http://www.amd.com/&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=wI0OM61LDIoiCfN1qZnTALISQujPZi7qSlxsPxtRgHs%3D%0A&s=3cd434e31bb32cc4cb893eda4914f65a45fea5e4865c6871ea0510a8ea056b51
> Libre software enthusiast          |                Mesa and X developer
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/piglit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=wI0OM61LDIoiCfN1qZnTALISQujPZi7qSlxsPxtRgHs%3D%0A&s=39c14dd7d1408d2811ce65a0669f17b3643193f50b2d89a2abe5562597833bfd
> 


More information about the Piglit mailing list