[Piglit] [PATCH 02/11] glean/glsl1: Port illegal shader tests to piglit.

[Kenneth Graunke]

On 05/21/2014 06:51 AM, Brian Paul wrote:
> On 05/20/2014 04:31 PM, Matt Turner wrote:
>> From: Kenneth Graunke <kenneth at whitecape.org>
>>
>> ---
>>   tests/glean/tglsl1.cpp                             | 152
>> +--------------------
>>   tests/shaders/glsl1/COPYRIGHT                      |  31 +++++
>>   tests/shaders/glsl1/break-with-no-loop.frag        |   9 ++
>>   tests/shaders/glsl1/continue-with-no-loop.frag     |   9 ++
>>   .../shaders/glsl1/glsl-1.20-array-error-check.frag |  11 ++
>>   tests/shaders/glsl1/if-boolean-scalar-check.frag   |  11 ++
>>   tests/shaders/glsl1/illegal-assignment.frag        |   9 ++
>>   .../glsl1/preprocessor-test-extension-test-3.frag  |  10 ++
>>   tests/shaders/glsl1/syntax-error-check-1.frag      |   9 ++
>>   tests/shaders/glsl1/syntax-error-check-2.frag      |   8 ++
>>   tests/shaders/glsl1/syntax-error-check-3.frag      |   9 ++
>>   .../glsl1/t-intermediate-add-unary-math.frag       |   8 ++
>>   tests/shaders/glsl1/undefined-variable.frag        |   9 ++
>>   13 files changed, 134 insertions(+), 151 deletions(-)
>>   create mode 100644 tests/shaders/glsl1/COPYRIGHT
>>   create mode 100644 tests/shaders/glsl1/break-with-no-loop.frag
>>   create mode 100644 tests/shaders/glsl1/continue-with-no-loop.frag
>>   create mode 100644 tests/shaders/glsl1/glsl-1.20-array-error-check.frag
>>   create mode 100644 tests/shaders/glsl1/if-boolean-scalar-check.frag
>>   create mode 100644 tests/shaders/glsl1/illegal-assignment.frag
>>   create mode 100644
>> tests/shaders/glsl1/preprocessor-test-extension-test-3.frag
>>   create mode 100644 tests/shaders/glsl1/syntax-error-check-1.frag
>>   create mode 100644 tests/shaders/glsl1/syntax-error-check-2.frag
>>   create mode 100644 tests/shaders/glsl1/syntax-error-check-3.frag
>>   create mode 100644
>> tests/shaders/glsl1/t-intermediate-add-unary-math.frag
>>   create mode 100644 tests/shaders/glsl1/undefined-variable.frag
> 
> Can you remind me how these .frag shaders are run?  I looked for a bit
> but couldn't figure it out.
> 
> In the interest of test organization, would it be better if these tests
> were in tests/spec/glsl-*/compiler/ ?
> 
> -Brian

Normally, there's an import_glsl_parser_tests call that searches for all
.vert/.frag/.geom tests in a directory (and subdirectories).  I thought
we had one for the 'shaders' directory, but maybe there isn't.  Strange.

I know Dylan had code in progress to just find all .frag/.vert/.geom
tests out of tests/ and generated_tests/ and try to use them as
glslparsertests - any that had a valid config block would be
automatically picked up.  I don't think that's landed though.

I suppose we could put them in tests/spec/glsl-1.[12]0/compiler/.  It
would probably be better.

--Ken

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140521/5f1c0123/attachment.sig>