[Piglit] [PATCH] Fix require extension usage -- prepend GL_ and GLX_ in missing places

Brian Paul brianp at vmware.com
Tue May 27 06:16:32 PDT 2014

On 05/24/2014 05:31 PM, Emil Velikov wrote:
> On 24/05/14 22:10, Ilia Mirkin wrote:
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> ---
>> This doesn't actually end up mattering for the GLX tests because they do a
>> substr-based search in the overall extension string. But for the GL tests it
>> matters because it looks for exact matches in an array.
>> May as well fix the GLX tests while I'm at it, in case they ever move to the
>> array mechanism.
> Nice catches Ilia.
> With this patch - all egl, gl and glx extensions have their respective prefix.
> This way people (like me) should have less of a incentive to forget them.

Maybe the piglit_require_extension() functions should assert that the 
first two characters of the string are "GL".


More information about the Piglit mailing list