[Piglit] [PATCH] summary: fix support for old results file with duplicated subtests
kenneth at whitecape.org
Wed May 28 21:59:22 PDT 2014
On 05/28/2014 07:17 PM, Ilia Mirkin wrote:
> Old files have duplicated entries for each subtest, in addition to a
> filled subtest dictionary. Detect that the current test name is also a
> subtest and treat it as though it were a complete test. This may have
> false-negatives, but they're unlikely given test/subtest naming
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> Dylan, I'm sure you hate this, but it does seem to work for me. Not sure where
> you are with your fix, but this is a tool that lots of people use, so it does
> need to be addressed. And keep in mind that by now there are both the "old"
> and "new" formats running around, so just slapping a version number in there
> won't be enough.
Seriously? We fixed a bug. Subtests were *broken* - it stored insane
amounts of duplicate data in the files, to work around a bug in the
tools that processed those data files. This caused huge amounts of
wasted space and confusion.
I don't understand the whole "let's not re-run Piglit to get a proper
baseline unless something breaks" thinking. It only takes 10-15 minutes
to do a full Piglit run here. Taking a proper baseline allows you to
have confidence that any changes you see were caused by your patches,
and not by other people's changes to Mesa or Piglit. It just seems like
Have things gotten to the point where we can't even fix a bug without
people requesting reverts or workarounds? It's bad enough that people
keep insisting that we have to make this software work on 4 year old
Dylan's patches were on the list waiting for over a month, and bumped
after two weeks, and AFAICS fix a long-standing bug. All people have to
do is re-run Piglit to get data files that aren't *broken*. If the
Piglit community won't even let us commit bug fixes, I don't know why I
should continue contributing to this project.
(Ilia - this isn't complaining about you specifically - it's just the
attitude of the community in general I've observed over the last few
months that frustrates me. It seems like any time we commit anything,
there are very vocal objections and people calling for reverts. And
that really frustrates me.)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: OpenPGP digital signature
More information about the Piglit