[Piglit] [PATCH 1/2] util: add a simple set of matrix functions

[Brian Paul]

On Fri, May 30, 2014 at 10:48 AM, Jose Fonseca <jfonseca at vmware.com> wrote:

>
> Series looks good at a glance.  Just one minor remark inline.
>
>
> > + */
> > +
> > +
> > +#ifndef PIGLIT_MATRIX_H
> > +#define PIGLIT_MATRIX_H
> > +
> > +
> > +#ifdef __cplusplus
> > +extern "C" {
> > +#endif
> > +
> > +
> > +#include <stdbool.h>
>
> It's not generally safe to add #includes inside `extern "C" { ... }`,
> because some system headers may use C++ internally (which would cause an
> error), and as matter of fact, some windows headers do precisely that.
>  (Though I'm sure stdbool.h is probably safe.) But as rule of thumb, all
> #includes should be before `extern "C" { ... }`.
>

Yes, right. Thanks!

-Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140530/a6fec080/attachment.html>