[Piglit] [PATCH 1/7] cmake: Require Visual Studio 2013.

[Jose Fonseca]

> Have a strange feeling that the menu says "VS2013 x86..."

Yes, good catch. Thanks for the review.

Jose

________________________________________
From: Emil Velikov <emil.l.velikov at gmail.com>
Sent: 07 November 2014 17:56
To: Jose Fonseca; piglit at lists.freedesktop.org
Cc: emil.l.velikov at gmail.com
Subject: Re: [Piglit] [PATCH 1/7] cmake: Require Visual Studio 2013.

On 07/11/14 14:21, jfonseca at vmware.com wrote:
> From: José Fonseca <jfonseca at vmware.com>
>
> Verified that cmake aborts with MSVS 2012.
>
It feels so good. Thank you Jose :)
Just a silly question below

[snip]
> diff --git a/README b/README
> index d3321a4..b344c16 100644
> --- a/README
> +++ b/README

> @@ -154,7 +154,7 @@ Install python mako.
>    > c:\Python27\Scripts\pip.exe install mako
>
>  Open Visual Studio Command Prompt.
> -Start Menu->All Programs->Microsoft Visual Studio 2010->Visual Studio Tools->Visual Studio Command Prompt (2010)
> +Start Menu->All Programs->Visual Studio 2013->Visual Studio Tools->VS2012 x86 Native Tools Command Prompt
Have a strange feeling that the menu says "VS2013 x86..."

Either way the series looks good.
FWIW Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Cheers,
Emil