[Piglit] [PATCH] arb_separate_shader_object: Silence GCC maybe-uninitialized warnings.

Brian Paul brianp at vmware.com
Thu Nov 13 07:47:04 PST 2014


On 11/12/2014 03:15 PM, Vinson Lee wrote:
> ValidateProgramPipeline.c:345:25: warning: 'prog_tes' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    build_and_validate_pipe(pipe, true,
>                           ^
> ValidateProgramPipeline.c:345:25: warning: 'prog_tcs' may be used uninitialized in this function [-Wmaybe-uninitialized]
> ValidateProgramPipeline.c:383:26: warning: 'prog_vs_gs' may be used uninitialized in this function [-Wmaybe-uninitialized]
>     build_and_validate_pipe(pipe, false,
>                            ^
> ValidateProgramPipeline.c:345:25: warning: 'prog_gs' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    build_and_validate_pipe(pipe, true,
>                           ^
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   tests/spec/arb_separate_shader_objects/ValidateProgramPipeline.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/spec/arb_separate_shader_objects/ValidateProgramPipeline.c b/tests/spec/arb_separate_shader_objects/ValidateProgramPipeline.c
> index a35ed7e..a2741aa 100644
> --- a/tests/spec/arb_separate_shader_objects/ValidateProgramPipeline.c
> +++ b/tests/spec/arb_separate_shader_objects/ValidateProgramPipeline.c
> @@ -235,8 +235,8 @@ piglit_init(int argc, char **argv)
>   {
>   	GLint vs, fs, gs, tes, tcs;
>   	GLuint pipe;
> -	GLint prog_vs, prog_fs, prog_gs, prog_tcs, prog_tes, prog_tess;
> -	GLint prog_vs_fs, prog_vs_gs;
> +	GLint prog_vs, prog_fs, prog_gs = 0, prog_tcs = 0, prog_tes = 0, prog_tess;
> +	GLint prog_vs_fs, prog_vs_gs = 0;
>   	GLint separable;
>   	int version;
>
>

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the Piglit mailing list