[Piglit] [PATCH 2/2] glx_ext_create_context_es2_profile: Update versions.

Brian Paul brianp at vmware.com
Fri Nov 14 07:45:57 PST 2014


For both: Reviewed-by: Brian Paul <brianp at vmware.com>

On 11/14/2014 07:57 AM, jfonseca at vmware.com wrote:
> From: José Fonseca <jfonseca at vmware.com>
>
> Tested with NVIDIA drivers.
> ---
>   .../glx_arb_create_context/invalid-es-version.c    | 23 +++++++---------------
>   1 file changed, 7 insertions(+), 16 deletions(-)
>
> diff --git a/tests/spec/glx_arb_create_context/invalid-es-version.c b/tests/spec/glx_arb_create_context/invalid-es-version.c
> index d023679..3bae0ba 100644
> --- a/tests/spec/glx_arb_create_context/invalid-es-version.c
> +++ b/tests/spec/glx_arb_create_context/invalid-es-version.c
> @@ -81,28 +81,19 @@ int main(int argc, char **argv)
>   	piglit_require_glx_extension(dpy, "GLX_ARB_create_context_profile");
>   	piglit_require_glx_extension(dpy, "GLX_EXT_create_context_es2_profile");
>
> -	/* The GLX_EXT_create_context_es2_profile spec says:
> +	/* The latest version of GLX_EXT_create_context_es2_profile spec says:
>   	 *
> -	 *     "... If the version requested is 2.0, and the
> -	 *     GLX_CONTEXT_ES2_PROFILE_BIT_EXT bit is set in the
> -	 *     GLX_CONTEXT_PROFILE_MASK_ARB attribute (see below),
> -	 *     then the context returned will implement OpenGL ES
> -	 *     2.0. This is the only way in which an implementation
> -	 *     may request an OpenGL ES 2.0 context."
> +	 *     "If the version requested is a valid and supported OpenGL-ES
> +	 *     version, and the GLX_CONTEXT_ES_PROFILE_BIT_EXT bit is set in
> +	 *     the GLX_CONTEXT_PROFILE_MASK_ARB attribute (see below), then the
> +	 *     context returned will implement the OpenGL ES version
> +	 *     requested."
>   	 *
>   	 * Try a bunch of OpenGL ES versions that don't exist.
>   	 */
>   	pass = try_version(1, 2) && pass;
>   	pass = try_version(2, 1) && pass;
> -	pass = try_version(3, 0) && pass;
> -
> -	/* These versions of ES exist, but future versions of the GLX
> -	 * extension may add the ability to create contexts with these
> -	 * versions.  When that happens, these checks will need to be
> -	 * predicated by the non-existence of that extension.
> -	 */
> -	pass = try_version(1, 0) && pass;
> -	pass = try_version(1, 1) && pass;
> +	pass = try_version(3, 2) && pass;
>
>   	GLX_ARB_create_context_teardown();
>
>



More information about the Piglit mailing list