[Piglit] [PATCH 22/45] gen_shader_bit_encoding_tests.py: cleanup remaining style issues

Matt Turner mattst88 at gmail.com
Fri Nov 14 14:10:27 PST 2014


On Wed, Nov 12, 2014 at 3:46 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  generated_tests/gen_shader_bit_encoding_tests.py | 32 +++++++++++++-----------
>  1 file changed, 18 insertions(+), 14 deletions(-)
>
> diff --git a/generated_tests/gen_shader_bit_encoding_tests.py b/generated_tests/gen_shader_bit_encoding_tests.py
> index aaf0863..4808c6f 100644
> --- a/generated_tests/gen_shader_bit_encoding_tests.py
> +++ b/generated_tests/gen_shader_bit_encoding_tests.py
> @@ -60,16 +60,16 @@ Functions = collections.namedtuple(
>  # shader_runner [test] sections. Don't test NaN, since it has many
>  # representations. Don't test subnormal values, since hardware might
>  # flush them to zero.
> -test_data = {
> +TEST_DATA = {
>      # Interesting floating-point inputs
>      'mixed':                        (2.0, 9.5, -4.5, -25.0),
> -    '0.0':                          vec4( 0.0), # int 0
> +    '0.0':                          vec4(0.0), # int 0
>      '-0.0':                         vec4(-0.0), # INT_MIN
> -    '1.0':                          vec4( 1.0),
> +    '1.0':                          vec4(1.0),
>      '-1.0':                         vec4(-1.0),
> -    'normalized smallest':          vec4( 1.1754944e-38),
> +    'normalized smallest':          vec4(1.1754944e-38),

The extra spaces are for readability, so you can quickly recognize
that the values on consecutive lines are the same, except for the
sign. If you want to remove the spaces, then replace when with an
explicit + instead.


More information about the Piglit mailing list