[Piglit] [PATCH v4] Add tests arb_conditional_render_inverted

Brian Paul brianp at vmware.com
Mon Nov 17 07:21:52 PST 2014


On 11/15/2014 08:56 PM, Tobias Klausmann wrote:
> Adopted tests from NV_conditional_render
>
> Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>

In several places you have

config.supports_gl_compat_version = 10;

and later

piglit_require_gl_version(30);

I think you could just specify config.supports_gl_compat_version = 30 
and omit the piglit_require_gl_version(30);

It's a shame this duplicates so much code from the NV_conditional_render 
tests.  Another option might be to update the existing tests to take an 
"inverted" command line argument to test the 
GL_ARB_conditional_render_inverted extension.  Though the tests should 
then alternately accept OpenGL 3.0 support instead of NV_conditional_render.

Thoughts?

-Brian






More information about the Piglit mailing list