[Piglit] [PATCH 2/2] framework/backends/junit: Prepend command line to stdout.

[Dylan Baker]

On Friday, November 21, 2014 07:37:20 PM Jose Fonseca wrote:
> Dylan,
> 
> I'm not sure you guys are still using the junit backend regularly or 
> not.  Would be the change below OK?
> 
> BTW, I finished transition all my jenkins' piglit jobs to the junit backend.
> 
> Feel free to remove the summary-junit code, or let me know if you rather 
> I do it.

Would you do it please?

> 
> Jose

We are still using it regularly, Mark is our guy that runs the Jenkins
stuff, I've CC'd him to see what he thinks.

> 
> On 20/11/14 12:06, jfonseca at vmware.com wrote:
> > From: José Fonseca <jfonseca at vmware.com>
> >
> > Showing the command line of the test is quite useful, specially when
> > diagnosing failures.
> >
> > Unfortunately JUnit format allows no better place to have it other than
> > stdout/stderr.
> > ---
> >   framework/backends/junit.py | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/framework/backends/junit.py b/framework/backends/junit.py
> > index 1c27e98..59d06c6 100644
> > --- a/framework/backends/junit.py
> > +++ b/framework/backends/junit.py
> > @@ -144,6 +144,9 @@ class JUnitBackend(FileBackend):
> >           out = etree.SubElement(element, 'system-out')
> >           out.text = data['out']
> >
> > +        # Prepend command line to stdout
> > +        out.text = data['command'] + '\n' + out.text
> > +

If Marks okay with it.

Otherwise I sent out a series a couple months ago titled 
'Junit backend: add more data to the junit output', the last patch of
that series puts the command in the failure message attribute, of
course, that means only failures will have the command attached.

> >           # Add stderr
> >           err = etree.SubElement(element, 'system-err')
> >           err.text = data['err']
> >
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20141121/99b93023/attachment.sig>