[Piglit] [PATCH 3/4] utils: add initial WAFFLE_WGL support

Emil Velikov emil.l.velikov at gmail.com
Sun Nov 23 07:09:10 PST 2014


On 23/11/14 09:38, Jose Fonseca wrote:
> On 21/11/14 19:52, Emil Velikov wrote:
[snip]
>> --- /dev/null
>> +++ b/tests/util/piglit-framework-gl/piglit_wgl_framework.c
[snip]
>> +static void
>> +enter_event_loop(struct piglit_winsys_framework *winsys_fw)
>> +{
>> +
>> +    /* FINISHME: Write event loop for Windows.
>> +     *
>> +     * Until we have proper Windows/WGL support, give the user enough
>> +     * time to view the window by sleeping.
>> +     */
>> +    Sleep(8000);
> 
> Instead of Sleep for 8 secs, you could do
> 
>   fprintf(stderr, "Press any key when done.\n");
>   getchar().
> 
> It would be more practical, and self-documenting.
> 
Makes sense. Unless there are other comments I'll amend before pushing.
The latter of which will happen after waffle 1.5.0 is rolled out.

Thanks
Emil


More information about the Piglit mailing list