[Piglit] [PATCH] summary.py: escape \ from Windows results when creating folders on Linux

Emil Velikov emil.l.velikov at gmail.com
Sun Nov 23 11:16:27 PST 2014

Afaict in some cases we don't use posixpath, as "key" ends up with a mix
of both \ and /. Any ideas what/where to look to fix this properly ?


On 23/11/14 17:54, Dylan Baker wrote:
> Isn't this why we were using posixpath explicitly?
> On Nov 23, 2014 7:15 AM, "Emil Velikov" <emil.l.velikov at gmail.com> wrote:
>> On 23/11/14 09:46, Jose Fonseca wrote:
>>> On 22/11/14 19:36, Emil Velikov wrote:
>>>> Seemingly this is sufficient for a Windows piglit run/result file to be
>>>> ran under Linux and the correct directory structure (and html) to be
>>>> generated.
>>>> Unfortunately my python-fu is a bit short so I'm not sure if(how much)
>>>> this will backfire when used on Windows with either Linux or Windows
>>>> result file.
>>>> v2: Attempt to handle Linux results on Windows.
>>> I think v2 is not necessary. '/' should work just fine. But without
>>> testing I can't claim I'm sure.
>> temp_path is used to create the path via makedirs a few lines below.
>> Considering how picky the latter is, on Linux, I've decided to go the
>> explicit route :P Will try to give it a test some time in the week.
>> -Emil
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit

More information about the Piglit mailing list