[Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

[Emil Velikov]

On 25/11/14 18:45, Mark Janes wrote:
> This patched fixed the gl tests, but I encountered the same error for
> gles1/gles2/gles3.
> 
> Piglit built for me when I added the same link instruction to:
> 
> tests/util/CMakeLists.gles1.txt
> tests/util/CMakeLists.gles2.txt
> tests/util/CMakeLists.gles3.txt
> 
Please don't. A slightly better patch is on it's way.

> Is there a more specific (GLES) link instruction that should be used,
> instead of linking the gles tests against GL?
> 
Things are not as black and white as you might think. Most of piglit
uses what I call "target-less rules", which means that when one does

   add_definitions ( -DPIGLIT_USE_GLX )
or
   link_libraries(${OPENGL_gl_LIBRARY})

the rule is applied for up-to XX (don't remember the limit) cmake files.
Meaning that despite the PIGLIT_USE_GLX define being inside
tests/util/CMakeLists.gl.txt it will be applied when building any of the
es* targets.

So if you build everything in one go, and then you're interested in
running the es* tests on a libGL(glx)-less setup if won't work :\

Things are rather messy...

Cheers,
Emil