[Piglit] [PATCH 1/2] cl: Add cospi tests

Tom Stellard tom at stellard.net
Fri Oct 3 06:26:01 PDT 2014


On Thu, Oct 02, 2014 at 04:12:49PM -0500, Aaron Watry wrote:
> On Wed, Oct 1, 2014 at 2:39 PM, Tom Stellard <tom at stellard.net> wrote:
> > On Mon, Sep 29, 2014 at 10:01:06AM -0500, Aaron Watry wrote:
> >> v2: Remove stray ', pi' in Arg0 list
> >>
> > Reviewed-by: Tom Stellard <thomas.stellard at amd.com>
> 
> Thanks, Tom.
> 
> Was this for this one patch, or have you had a change to look at the
> rest of the series as well (v2 of cospi/sinpi, v1 of the 7 others)?
> 

Yes, you can add my r-b for all 9 patches.

-Tom

> --Aaron
> 
> >> CC: Bruno Jiménez <brunojimen at gmail.com>
> >> Signed-off-by: Aaron Watry <awatry at gmail.com>
> >> ---
> >>  generated_tests/generate-cl-math-builtins.py | 10 ++++++++++
> >>  1 file changed, 10 insertions(+)
> >>
> >> diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py
> >> index 531106d..6677c1f 100644
> >> --- a/generated_tests/generate-cl-math-builtins.py
> >> +++ b/generated_tests/generate-cl-math-builtins.py
> >> @@ -42,6 +42,7 @@ CLC_VERSION_MIN = {
> >>      'copysign' : 10,
> >>      'cos' : 10,
> >>      'cosh' : 10,
> >> +    'cospi' : 10,
> >>      'fabs' : 10,
> >>      'floor' : 10,
> >>      'fmod' : 10,
> >> @@ -172,6 +173,15 @@ tests = {
> >>          ],
> >>          'tolerance' : 4
> >>      },
> >> +    'cospi' : {
> >> +        'arg_types' : [F, F],
> >> +        'function_type': 'ttt',
> >> +        'values' : [
> >> +            [1.0, cos(pi*pi/2), cos(pi*3*pi/2), cos(2*pi*pi), cos(pi*1.12345)], # Result
> >> +            [0.0, pi / 2,       3 * pi / 2,     2 * pi,       1.12345        ]  # Arg0
> >> +        ],
> >> +        'tolerance' : 4
> >> +    },
> >>      'fabs' : {
> >>          'arg_types' : [F, F],
> >>          'function_type': 'ttt',
> >> --
> >> 1.9.1
> >>
> >> _______________________________________________
> >> Piglit mailing list
> >> Piglit at lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list