[Piglit] [PATCH 1/1] cl: Add more sin/cos tests

Tom Stellard tom at stellard.net
Thu Oct 9 06:37:20 PDT 2014


On Wed, Oct 08, 2014 at 04:07:39PM -0400, Jan Vesely wrote:
> On Wed, 2014-10-08 at 09:49 -0500, Aaron Watry wrote:
> > Reviewed-by: Aaron Watry <awatry at gmail.com>
> 
> thanks.
> btw: do these pass on your system?
> 
> > 
> > Do you need someone to push this for you?
> 
> yes pls. my access request bug is stale for some reason
> 

Can you send me the bugzilla link for your account request.

-Tom

> jan
> 
> > 
> > --Aaron
> > 
> > On Fri, Oct 3, 2014 at 7:27 PM, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> > > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > > ---
> > >
> > > the newly added values fail on my TURKS gpu.
> > > All tests still pass on Intel CPU.
> > >
> > >  generated_tests/generate-cl-math-builtins.py | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py
> > > index fcdcc94..0551a89 100644
> > > --- a/generated_tests/generate-cl-math-builtins.py
> > > +++ b/generated_tests/generate-cl-math-builtins.py
> > > @@ -113,8 +113,8 @@ tests = {
> > >          'arg_types' : [F, F],
> > >          'function_type': 'ttt',
> > >          'values' : [
> > > -            [1.0, 0.0,    -1.0, 0.0,        1.0,    cos(1.12345), -0.9258790228548379], # Result
> > > -            [0.0, pi / 2, pi,   3 * pi / 2, 2 * pi, 1.12345, pow(2,120)] # Arg0
> > > +            [1.0, 0.0,    -1.0, 0.0,        1.0,    cos(1.12345), cos(7), cos(8), cos(pow(2,20)), cos(pow(2,24)), cos(pow(2,120)), float("nan")], # Result
> > > +            [0.0, pi / 2, pi,   3 * pi / 2, 2 * pi, 1.12345, 7, 8, pow(2,20), pow(2,24), pow(2,120), float("nan")] # Arg0
> > >          ],
> > >          'tolerance' : 2
> > >      },
> > > @@ -185,8 +185,8 @@ tests = {
> > >          'arg_types' : [F, F],
> > >          'function_type': 'ttt',
> > >          'values' : [
> > > -            [0.0, 1.0,   0.0, -1.0,       0.0,    sin(2.234567)], # Result
> > > -            [0.0, pi / 2, pi, 3 * pi / 2, 2 * pi, 2.234567] # Arg0
> > > +            [0.0, 1.0,   0.0, -1.0,       0.0,    sin(2.234567), sin(7), sin(8), sin(pow(2,20)), sin(pow(2,24)), sin(pow(2,120)), float("nan")], # Result
> > > +            [0.0, pi / 2, pi, 3 * pi / 2, 2 * pi, 2.234567, 7, 8, pow(2,20), pow(2,24), pow(2,120), float("nan")] # Arg0
> > >          ],
> > >          'tolerance': 2
> > >      },
> > > --
> > > 1.9.3
> > >
> 
> -- 
> Jan Vesely <jan.vesely at rutgers.edu>




More information about the Piglit mailing list