[Piglit] [PATCH 1/2] Ported the glsl1 test from Glean to Piglit.

Matt Turner mattst88 at gmail.com
Fri Oct 17 12:05:02 PDT 2014

On Wed, Oct 15, 2014 at 11:24 AM, Laura Ekstrand <laura at jlekstrand.net> wrote:
> It's really not a good use of time to check for overlaps between the glsl1
> tests and the shader runner tests, because that would take a lot of
> searching.

I don't really think so. I've already deleted a pile of these tests:
check git log tests/glean/tglsl1.cpp. It's usually a grep or two for
each set of tests to conclusively determine that we're already testing
that functionality.

I made a small list of categories of remaining tests and things we
should test in piglit a while back when looking through tglsl1.cpp
(i.e., things that aren't tested elsewhere):

Swizzles: swizzles can be .rgba/.xyzw/.stpq but not a mix of them.
Probably a generator to test all possible combinations? Or just some
parser tests would probably be sufficient.
Make sure to test swizzling expressions, e.g., (a + b).zyx
Writemasks: Maybe part of the previous generator


Nested function calls


Chained assignments
a = b = c;


Short circuit evaluation
a && b -> set a = false. make b a function call with side-effects
a || b -> set a = true.  ...


But most of the tglsl1.cpp tests can just be deleted outright.

More information about the Piglit mailing list