[Piglit] [PATCH] Replaced calls from assert(glGetError()==0) with piglit_check_gl_error()

Laura Ekstrand laura at jlekstrand.net
Sun Oct 19 15:40:46 PDT 2014


if (!piglit_check_gl_error(GL_NO_ERROR)
          piglit_report_result(PIGLIT_FAIL);

is better style; it's clearer and easier to read.

Laura

On Sat, Oct 18, 2014 at 10:40 AM, Juliet Fru <julietfru at gmail.com> wrote:

>
>
> Hello Ilia,
>
> assert(glGetError() == 0) will abort (and thus fail) the test if
>> there's an error. However I don't see anything in
>> piglit_check_gl_error that will mark the test as failed. Perhaps you
>> need to do like
>>
>> if (!piglit_check_gl_error(GL_NO_ERROR))
>> piglit_report_result(PIGLIT_FAIL);
>>
>> or something along those lines.
>>
>>
> Thanks very much for the reply. I would make the necessary changes ASAP.
>
> Regards,
> Juliet
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20141019/7c3c2c8f/attachment.html>


More information about the Piglit mailing list