[Piglit] [PATCH] libpiglit: Do not set CMAKE_SOVERSION on OpenBSD.

[Brian Paul]

On 10/18/2014 04:44 PM, Vinson Lee wrote:
> This patch fixes build regression on OpenBSD introduced with commit
> 4efb025fcac0b37d04ab759ab15055f27cea94f8 'libpiglit: Set CMAKE SOVERSION
> for internal libraries to "0"'.
>
> Linking CXX shared library ../../../../lib/libpiglitutil_gl.so
> /usr/bin/ld: cannot find -llibpiglitutil.so.0
> collect2: ld returned 1 exit status
> target_api/gl/tests/util/CMakeFiles/piglitutil_gl.dir/build.make:515: recipe for target
> 'lib/libpiglitutil_gl.so.0' failed
>
> Bugzilla: https://urldefense.proofpoint.com/v1/url?u=https://bugs.freedesktop.org/show_bug.cgi?id%3D84969&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=xBRxMntB%2BIkanTQgZZCONJJxobflQiN3CKzmP8ncURQ%3D%0A&s=bcdd3b62a52421072e4325eb6a5b6a9096b8e5fb7424ddff197e3ac550102f20
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   cmake/piglit_util.cmake | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/cmake/piglit_util.cmake b/cmake/piglit_util.cmake
> index 45143d2..411fa54 100644
> --- a/cmake/piglit_util.cmake
> +++ b/cmake/piglit_util.cmake
> @@ -84,6 +84,8 @@ function(piglit_add_library name)
>           install(TARGETS ${name} DESTINATION ${PIGLIT_INSTALL_LIBDIR}/lib)
>       endif(WIN32)
>       add_dependencies(${name} piglit_dispatch_gen)
> -    set_target_properties(${name} PROPERTIES SOVERSION "0")
> +    if(NOT ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD")
> +        set_target_properties(${name} PROPERTIES SOVERSION "0")
> +    endif()
>
>   endfunction(piglit_add_library)
>

Looks OK to me.

Reviewed-by: Brian Paul <brianp at vmware.com>