[Piglit] [PATCH] Replaced calls from assert(glGetError()==0) with piglit_check_gl_error()

[Brian Paul]

On 10/20/2014 04:49 AM, Juliet Fru wrote:
> Hello,
>
> Here is the updated patch. I tried using git send-email but my system is
> having some issues. Let me know if there are any problems.

There's a few issues:


> diff --git a/tests/fbo/fbo-cubemap.c b/tests/fbo/fbo-cubemap.c
> index 2eb45af..7603b14 100644
> --- a/tests/fbo/fbo-cubemap.c
> +++ b/tests/fbo/fbo-cubemap.c
> @@ -82,7 +82,8 @@ create_cube_fbo(void)
>  			level++;
>  		}
>  	}
> -	assert(glGetError() == 0);
> +	if (!piglit_check_gl_error(GL_NO_ERROR)
> +		piglit_report_result(PIGLIT_FAIL);

There needs to be a closing ')' on the if statement.  This seems to be 
missing in many places.  Did you compile the code?


>
>  	glGenFramebuffersEXT(1, &fb);
>  	glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, fb);
> @@ -97,7 +98,8 @@ create_cube_fbo(void)
>  						  tex,
>  						  level);
>
> -			assert(glGetError() == 0);
> +			if (!piglit_check_gl_error(GL_NO_ERROR)
> +		piglit_report_result(PIGLIT_FAIL);
>

The indentation is wrong there.  There are several other places with 
similar problems.


>  			status = glCheckFramebufferStatusEXT (GL_FRAMEBUFFER_EXT);
>  			if (status != GL_FRAMEBUFFER_COMPLETE_EXT) {


-Brian