[Piglit] [PATCH] Updated sanity.py to reflect new Piglit version of the read pixels sanity test.

[Dylan Baker]

On Tuesday, October 21, 2014 03:19:41 PM Ilia Mirkin wrote:
> On Tue, Oct 21, 2014 at 3:11 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> > On Tuesday, October 21, 2014 02:39:06 PM Ilia Mirkin wrote:
> >> On Tue, Oct 21, 2014 at 2:35 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> >> > Hi Laura,
> >> >
> >> > You should rebase your piglit work, this patch wont apply to master, as
> >> > I landed some changes to get rid of the need for a bunch of the test
> >> > wrappers. The big change is that the -auto and -fbo stuff is added
> >> > automatically by the class now.
> >> >
> >> > It's also worth noting that the nested dictionary structure of
> >> > profile.tests actually gets flattened into a '/' separated single level
> >> > dictionary before the tests run, the way the code is written you can
> >> > just specify them as a flat dictionary to begin with. That's how the
> >> > current code works.
> >> >
> >> > All you really need to do is something like the following (I haven't
> >> > tested this but it should be close):
> >> >
> >> > from framework.profile import TestProfile
> >> > from framework.test import PiglitGLTest
> >> >
> >> > __all__ = ['profile']
> >> >
> >> > profile.tests['spec/!OpenGL 1.0/gl-1.0-readpixsanity'] = \
> >> >         PiglitGLTest('gl-1.0-readpixsanity', run_concurrent=True)
> >>
> >> I would like to voice an objection against specifying tests that
> >> way... it goes against the style in all.py. Also I have some changes
> >> in mind (but haven't had time to work on them yet) to propose a much
> >> cleaner/etc way of specifying tests, but which will be much easier to
> >> convert to if things are written in the "dictionary" style.
> >>
> >>   -ilia
> >>
> >
> > This is how sanity.py is currently implemented. If we want to change
> > that it should be done in a separate patch.
> 
> Ah OK. Then objection withdrawn :) I just didn't want this to become a
> thing where like old tests are done one way new tests are done some
> other way, and then you end up with an unmanageable mess of multiple
> ways being used of doing the same thing.
> 
>   -ilia

Cool.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20141021/2dfc4c97/attachment.sig>