[Piglit] [PATCH 1/6] README: Add simple-json and lxml as optional dependencies

Kenneth Graunke kenneth at whitecape.org
Fri Oct 24 11:31:19 PDT 2014


On Tuesday, October 21, 2014 11:23:44 AM Dylan Baker wrote:
> These are accelerated libraries that the python framework can optionally
> use to run faster.
> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  README | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/README b/README
> index 002ddd9..74bdc1d 100644
> --- a/README
> +++ b/README
> @@ -36,8 +36,14 @@ First of all, you need to make sure that the following 
are installed:
>    - GL, glu and glut libraries and development packages (i.e. headers)
>    - X11 libraries and development packages (i.e. headers)
>    - waffle (http://www.waffle-gl.org)
> -  - nose. Only needed for python framework tests
> -    (https://nose.readthedocs.org/en/latest/)
> +
> +Optionally you can install the following:

Optionally, you can ... (comma)

> +
> +  - nose. A python test framework, used for running the python framework
> +    test suite. (https://nose.readthedocs.org/en/latest/)
> +  - lxml. An accelerated python xml library using libxml2 (http://lxml.de/)
> +  - simple-json. A fast C based implementation of the python json library.
> +    (https://simplejson.readthedocs.org/en/latest/)

Shouldn't it be 'simplejson' (no hyphen)?  That's the name used on the 
website, in the URL, and in my distro's package name.

I sent out small nits on patches 1-4, but regardless, the series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

>  
>  Now configure the build system:
>  
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20141024/1cd57f99/attachment-0001.sig>


More information about the Piglit mailing list