[Piglit] Patch to test for ARB_clip_control v2

Ilia Mirkin imirkin at alum.mit.edu
Fri Oct 24 14:17:34 PDT 2014


Can you verify that your test fails with an incorrect implementation?
I just set nvc0 so that it always acts as if clip_halfz == 0, and the
test passed...

Also, you sent the patches inline just fine for mesa... can you do it
here as well? It enables people to review your patches...

  -ilia

On Fri, Oct 24, 2014 at 1:30 AM, Mathias Fröhlich
<Mathias.Froehlich at gmx.net> wrote:
>
> Hi,
>
> On Wednesday, October 22, 2014 15:31:43 Brian Paul wrote:
>> I just did a quick read-through and found a few things...
> Thanks!
>
> Attached a v2 with the following changes:
> Check for ARB_depth_buffer_float where used.
> Fix and extend comments. Especially the precision test.
> Introduce helper for reading and checking the clip control state.
> Split state and draw related parts into separate methods.
> Test for Push/PopAttrib.
>
> Please review!
>
> Greetings
>
> Mathias
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>


More information about the Piglit mailing list