[Piglit] [PATCH 2/2] gl-1.0-readpixsanity: Eliminate use of variable length arrays.

Jose Fonseca jfonseca at vmware.com
Wed Oct 29 09:38:07 PDT 2014

On 29/10/14 16:20, Jan Vesely wrote:
> On Wed, 2014-10-29 at 11:48 +0000, jfonseca at vmware.com wrote:
>> From: José Fonseca <jfonseca at vmware.com>
>> Non-standard GCC extension.
> just FYI, it's not GCC extension, it's c99 standard.

I think you're right.

I assumed it was not standard because per 
https://gcc.gnu.org/onlinedocs/gcc/Variable-Length.html GCC variable 
length array supports goes beyond C99 specs, and MSVC 2013 supposedly 
supports C99, but per 
this is *library*, not full syntax support.

 > maybe we can use more msvc compatible set of gcc flags (-std=c89
 > -pedantic? ) for code that needs to compile in windows

No, unfortunately that's too restrictive.  MSVC supports a few things 
beyond C89, so -std=c98/-pendantic ends up complaining about a bunch 
things that we use and are supported everywhere.


More information about the Piglit mailing list