[Piglit] [PATCH] shader_runner: Work around MSVC lacking strtoll
jfonseca at vmware.com
Wed Oct 29 17:05:00 PDT 2014
I've commented on the bug, but just noticed this review now after commenting.
> Does piglit have a place where wrapper functions like this should live?
I think that would be tests/util/piglit-util.h
But I suspect this change might break MSVC 2013 (which probably defines or declares the function)...
Like I said to Vinson, unless there is a major reason, I'd rather bump the minimum MSVC version required to build piglit to MSVC 2013, instead of having to deal older MSVC 2012 versions.
BTW, does anybody else on the maling list care for MSVC versions older than 2013? As they say, "speak now or forever hold your peace.. "
From: Piglit <piglit-bounces at lists.freedesktop.org> on behalf of Ian Romanick <idr at freedesktop.org>
Sent: 29 October 2014 21:34
To: piglit at lists.freedesktop.org
Cc: Ian Romanick
Subject: [Piglit] [PATCH] shader_runner: Work around MSVC lacking strtoll
From: Ian Romanick <ian.d.romanick at intel.com>
Does piglit have a place where wrapper functions like this should live?
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Cc: vlee at freedesktop.org
tests/shaders/shader_runner.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 1f93216..465d042 100644
@@ -31,6 +31,10 @@
+#define strtoll _strtoi64
Piglit mailing list
Piglit at lists.freedesktop.org
More information about the Piglit