[Piglit] [PATCH] shader_runner: Work around MSVC lacking strtoll

Jose Fonseca jfonseca at vmware.com
Thu Oct 30 03:35:59 PDT 2014

> That sounds great. Can we do the same with Mesa as well?

That's my hope too.  But we link Mesa/Gallium components with other internal components, so we can only move towards new MSVC once the rest of the product does.

And part of the difficulty is that we used to use MSVC that came bundled from Windows SDKs, as those are easier to use (unlike the whole Visual Studio, Windows SDK compiler can easily be ran from a network share), however Microsoft decided to stop bundling MSVC compilers in Windows SDK, which means newer Visual Studio needs to be installed on every build slave, which causes quite a few logistic challenges.  Anyway, I'm sure it's only a matter of time.   


From: Matt Turner <mattst88 at gmail.com>
Sent: 30 October 2014 04:27
To: Jose Fonseca
Cc: Ian Romanick; piglit at lists.freedesktop.org; Ian Romanick
Subject: Re: [Piglit] [PATCH] shader_runner: Work around MSVC lacking strtoll

On Wed, Oct 29, 2014 at 5:05 PM, Jose Fonseca <jfonseca at vmware.com> wrote:
> I've commented on the bug, but just noticed this review now after commenting.
>> Does piglit have a place where wrapper functions like this should live?
> I think that would be tests/util/piglit-util.h
> But I suspect this change might break MSVC 2013 (which probably defines or declares the function)...
> Like I said to Vinson, unless there is a major reason, I'd rather bump the minimum MSVC version required to build piglit to MSVC 2013, instead of having to deal older MSVC 2012 versions.

That sounds great. Can we do the same with Mesa as well?

More information about the Piglit mailing list