[Piglit] [PATCH] arb_gpu_shader_fp64: add basic uniform fs test with constant initializer

[Abdiel Janulgue]

On 02.09.2014 01:17, Matt Turner wrote:
> On Mon, Sep 1, 2014 at 5:13 AM, Abdiel Janulgue
> <abdiel.janulgue at linux.intel.com> wrote:
>> Passes on Nvidia hardware but crashes on Intel
>>
>> Signed-off-by: Abdiel Janulgue <abdiel.janulgue at linux.intel.com>
>> ---
>>   .../execution/fs-uniform.shader_test               |   26 ++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>   create mode 100644 tests/spec/arb_gpu_shader_fp64/execution/fs-uniform.shader_test
>>
>> diff --git a/tests/spec/arb_gpu_shader_fp64/execution/fs-uniform.shader_test b/tests/spec/arb_gpu_shader_fp64/execution/fs-uniform.shader_test
>> new file mode 100644
>> index 0000000..daeda37
>> --- /dev/null
>> +++ b/tests/spec/arb_gpu_shader_fp64/execution/fs-uniform.shader_test
>> @@ -0,0 +1,26 @@
>> +[require]
>> +GLSL >= 1.50
>> +GL_ARB_gpu_shader_fp64
>> +
>> +[vertex shader passthrough]
>> +
>> +[fragment shader]
>> +#extension GL_ARB_gpu_shader_fp64 : enable
>> +
>> +uniform double arg1;
>> +uniform double arg2;
>> +uniform double arg3;
>> +void main()
>> +{
>> +       double res = 3.0lf;
>
>  From looking at the patch it's unclear whether you're testing uniforms
> or initializers, but the subject I would have thought we were testing
> 'uniform initializers' and from the filename I would have thought we
> were testing uniforms.
>
> Which is it?
>

Sorry for the confusion. The test accounts for both conditions. On the 
current Intel driver with the initial fp64 feature turned on, a crash is 
triggered when a uniform value is compared with a constant. Anyway 
Tapani was able to fix this issue yesterday with some changes on top of 
my initial patch. I'm not actually sure if this test is necessary anymore.