[Piglit] [PATCH] test_result.mako: Fix bug introduced by d9f87269c28c

Emil Velikov emil.l.velikov at gmail.com
Wed Sep 3 10:29:14 PDT 2014


On 03/09/14 16:45, Dylan Baker wrote:
> On Wednesday, September 03, 2014 11:42:34 AM Ilia Mirkin wrote:
>> On Wed, Sep 3, 2014 at 11:35 AM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
>>> The commit above changed the template to take a single value rather than
>>> nearly a dozen, but the template arguments changed a few of the names to
>>> shorter versions, including environment to env. The template was updated
>>> incorrectly in the template, and environment has not been printed since
>>
>> The template was updated incorrectly in the template?
> 
> <sigh>
> 
> I'll fix that
> 
Reported-and-tested-by: Emil Velikov <emil.l.velikov at gmail.com>

Feel free to slap the above tag :-)

All that remains is the \ vs / (Win vs Unix) and somewhat fix it to work
across platforms - but more on that later on :P

Thanks
-Emil

>>
>>> then.
>>>
>>> This patch fixes this simple bug.
>>>
>>> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
>>
>> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>
>>> ---
>>>  templates/test_result.mako | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/templates/test_result.mako b/templates/test_result.mako
>>> index 42f336b..7baf05c 100644
>>> --- a/templates/test_result.mako
>>> +++ b/templates/test_result.mako
>>> @@ -61,11 +61,11 @@
>>>            <pre>${value.get('err', 'None') | h}</pre>
>>>          </td>
>>>        </tr>
>>> -    % if value.get('env') is not None:
>>> +    % if value.get('environment') is not None:
>>>        <tr>
>>>          <td>Environment</td>
>>>          <td>
>>> -          <pre>${value.get('env') | h}</pre>
>>> +          <pre>${value.get('environment') | h}</pre>
>>>          </td>
>>>        </tr>
>>>      % endif
>>> --
>>> 2.1.0
>>>
>>> _______________________________________________
>>> Piglit mailing list
>>> Piglit at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/piglit
>>>
>>>
>>> _______________________________________________
>>> Piglit mailing list
>>> Piglit at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/piglit



More information about the Piglit mailing list