[Piglit] [PATCH 1/1] cl: fix adding concurent tests

[Ilia Mirkin]

On Wed, Sep 3, 2014 at 7:28 PM, Tom Stellard <tom at stellard.net> wrote:
> On Wed, Sep 03, 2014 at 07:20:10PM -0400, Jan Vesely wrote:
>> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
>
> Reviewed-by: Tom Stellard <thomas.stellard at amd.com>
>
>> ---
>>
>> seemed wrong. Wonder if we can use concurrent tests.
>>
>
> If you have render-nodes enabled, then you can run the cl tests
> concurrently by adding the -c flag when running piglit.
>
> Render-nodes were enabled by default in the 3.16 kernel, so
> I think it may be too early to enable concurrent tests by default.

Conversely, you can use -1 to force single-threaded runs... seems like
it's not for piglit to worry about that. -c forces all tests to run
concurrently even if the test author said that it shouldn't run
concurrently with other things. Not sure how common that is in the CL
world though.

>
> -Tom
>
>>  tests/cl.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/cl.py b/tests/cl.py
>> index fd698fc..b59368d 100644
>> --- a/tests/cl.py
>> +++ b/tests/cl.py
>> @@ -21,7 +21,7 @@ def add_plain_test(group, name, args):
>>  def add_concurrent_test(group, name, args):
>>          test = PiglitTest(args)
>>          test.run_concurrent = true;
>> -        group[name] = PiglitTest(args)
>> +        group[name] = test
>>
>>  def add_plain_program_tester_test(group, name, path):
>>          add_plain_test(group, name, ['cl-program-tester', path])
>> --
>> 1.9.3
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit