[Piglit] [PATCH 1/2] ext_timer_query: add Windows support in time-elapsed.c
emil.l.velikov at gmail.com
Thu Sep 4 14:07:42 PDT 2014
On 04/09/14 21:56, Brian Paul wrote:
> On 09/04/2014 02:25 PM, Emil Velikov wrote:
>> Hi Brian,
>> Wouldn't it be better if we add a couple of wrapper functions: piglit_get_time
>> and piglit_sleep ? This way we'll be able to keep the tests clean and
>> OS-agnostic and avoid the trivial duplication introduced with the second
>> patch :)
> I want to do that too. But the two "get time" functions in the two test
> aren't identical (one returns float, the other int64, for example) and I don't
> have time right now to unify things.
I fear that's the most common case. Only if Meng-Lin Wu considered this when
writing the patches originally :'(
> I'd like to commit these as-is for the time being.
Apart from my hopeful thinking the patches look correct. I wrote almost the
the same thing for waffle.
More information about the Piglit