[Piglit] [PATCH] array-index-as-uint-02: Move test to proper location

Dylan Baker baker.dylan.c at gmail.com
Thu Sep 4 14:16:53 PDT 2014


This looks fine to me. I'm far from a GLSL expert, but it seem straight
forward enough that I'm willing to call it good.

Do you have push access? If you don't I'll push this tomorrow if no one
complains.

Reviewed-by: Dylan Baker <baker.dylan.c at gmail.com>

On Wednesday, September 03, 2014 03:32:37 PM tiffany wrote:
> ---
>  tests/glslparsertest/glsl2/array-index.frag           | 19 -------------------
>  .../array-index-as-uint-02.frag                       | 19 +++++++++++++++++++
>  2 files changed, 19 insertions(+), 19 deletions(-)
>  delete mode 100644 tests/glslparsertest/glsl2/array-index.frag
>  create mode 100644 tests/spec/glsl-1.30/compiler/structure-and-array-operations/array-index-as-uint-02.frag
> 
> diff --git a/tests/glslparsertest/glsl2/array-index.frag b/tests/glslparsertest/glsl2/array-index.frag
> deleted file mode 100644
> index 41af438..0000000
> --- a/tests/glslparsertest/glsl2/array-index.frag
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -/* From page 44 (page 50 of the PDF) of the GLSL 1.30 spec:
> - *
> - *    "Array elements are accessed using an expression whose type is int or uint."
> - *
> - * [config]
> - * expect_result: pass
> - * glsl_version: 1.30
> - * [end config]
> - */
> -#version 130
> -flat in uint i;
> -out vec4 color;
> -
> -const float a[4] = float[4](0.0, 1.0, 2.0, 3.0);
> -
> -void main()
> -{
> -	color = vec4(a[i]);
> -}
> diff --git a/tests/spec/glsl-1.30/compiler/structure-and-array-operations/array-index-as-uint-02.frag b/tests/spec/glsl-1.30/compiler/structure-and-array-operations/array-index-as-uint-02.frag
> new file mode 100644
> index 0000000..41af438
> --- /dev/null
> +++ b/tests/spec/glsl-1.30/compiler/structure-and-array-operations/array-index-as-uint-02.frag
> @@ -0,0 +1,19 @@
> +/* From page 44 (page 50 of the PDF) of the GLSL 1.30 spec:
> + *
> + *    "Array elements are accessed using an expression whose type is int or uint."
> + *
> + * [config]
> + * expect_result: pass
> + * glsl_version: 1.30
> + * [end config]
> + */
> +#version 130
> +flat in uint i;
> +out vec4 color;
> +
> +const float a[4] = float[4](0.0, 1.0, 2.0, 3.0);
> +
> +void main()
> +{
> +	color = vec4(a[i]);
> +}
> -- 
> 2.1.0
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140904/cde05076/attachment-0001.sig>


More information about the Piglit mailing list