[Piglit] [PATCH 1/1] results.py: Print warning when overwriting subtest results

Dylan Baker baker.dylan.c at gmail.com
Thu Sep 4 14:35:44 PDT 2014


On Thursday, September 04, 2014 05:25:56 PM Jan Vesely wrote:
> On Thu, 2014-09-04 at 13:39 -0700, Dylan Baker wrote:
> > On Wednesday, September 03, 2014 09:44:08 PM Ilia Mirkin wrote:
> > [snip]
> > > Hmmmm.... right. In the Test constructor:
> > > 
> > >         self.result = TestResult({'result': 'fail'})
> 
> removing this prevents any test from executing.

I sent a patch to remove setting it again in Test.run()

On second though I'm not as against having it, but I agree with Ilia
that we should just always turn it on. Since the only time someone
should hit that case is if they are adding a new test and haven't sent
it to the list.

-Dylan

[snip]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140904/f72fe400/attachment.sig>


More information about the Piglit mailing list