[Piglit] [PATCH] summary.py: Replace path separators in testrun names

Jason Ekstrand jason at jlekstrand.net
Fri Sep 5 11:53:33 PDT 2014


Dylan,
There's one more on line 196 that you're missing.  Wrapping that one in
escape_pathname fixes it up nicely.  With that change,

Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

--Jason


On Fri, Sep 5, 2014 at 11:35 AM, Jason Ekstrand <jason at jlekstrand.net>
wrote:

> Yeah, on second thought, not quite working...  I'll poke at it a bit.
>
>
> On Thu, Sep 4, 2014 at 10:11 PM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
>
>> Thanks a bunch Dylan.  It's working great for me.
>> --Jason
>>
>>
>> On Thu, Sep 4, 2014 at 5:11 PM, Dylan Baker <baker.dylan.c at gmail.com>
>> wrote:
>>
>>> On Friday, September 05, 2014 12:22:02 AM Emil Velikov wrote:
>>> > On 04/09/14 22:55, Dylan Baker wrote:
>>> > > On Thursday, September 04, 2014 10:49:10 PM Emil Velikov wrote:
>>> > >> On 04/09/14 21:54, Dylan Baker wrote:
>>> > >>> This solves the bug of running piglit run -n 'wip/foo' which
>>> causes a
>>> > >>> number of issues in the html summary generation.
>>> > >>>
>>> > >> From a quick look it seems that it might help with a funny issue
>>> that I'm seeing:
>>> > >>
>>> > >> Whenever piglit is ran on Windows the testname uses \\ as path
>>> separator (in
>>> > >> some cases / is also used). When trying to generate summary under
>>> Linux, the
>>> > >> script ends up generating a ton of spec\extenstion_name\test files,
>>> rather
>>> > >> than structuring everything as normal.
>>> > >
>>> > > The mixed '/' and '\\' issue is known, it's mostly due to hard
>>> coding of
>>> > > values. It's on my list (although pretty far down) of things to fix.
>>> > >
>>> > In case this makes it in time for XDC2014 there will be a nice bottle
>>> of wine
>>> > waiting for you ;-)
>>> >
>>> > -Emil
>>> >
>>>
>>> Well, I don't get travel budget, so you'll have to ship me that bottle
>>> :)
>>>
>>> _______________________________________________
>>> Piglit mailing list
>>> Piglit at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/piglit
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140905/72ee1b67/attachment.html>


More information about the Piglit mailing list