[Piglit] [PATCH 2/2] draw-pixels: update BYTE_TO_FLOAT() macro to match Mesa

Anuj Phogat anuj.phogat at gmail.com
Thu Sep 25 14:56:33 PDT 2014


On Thu, Sep 25, 2014 at 6:52 AM, Brian Paul <brianp at vmware.com> wrote:
> Use Mesa's UBYTE_TO_FLOAT_TEX() arithmetic.  This lets Mesa pass the
I think you mean BYTE_TO_FLOAT_TEX() here.

> test.  No regression with nvidia's driver either.
> ---
>  tests/general/draw-pixels.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/general/draw-pixels.c b/tests/general/draw-pixels.c
> index 27b1675..65f5122 100644
> --- a/tests/general/draw-pixels.c
> +++ b/tests/general/draw-pixels.c
> @@ -37,7 +37,7 @@
>  #define UBYTE_TO_FLOAT(u) ((float) u / 255.0F)
>
>  /** Convert GLbyte in [-128,127] to GLfloat in [-1.0,1.0] */
> -#define BYTE_TO_FLOAT(B)    ((2.0F * (B) + 1.0F) * (1.0F/255.0F))
> +#define BYTE_TO_FLOAT(B)    ((B) == -128 ? -1.0F : (B) * (1.0F/127.0F))
>
>  /** Convert GLushort in [0,65535] to GLfloat in [0.0,1.0] */
>  #define USHORT_TO_FLOAT(S)  ((GLfloat) (S) * (1.0F / 65535.0F))
> --
> 1.7.10.4
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit

Both patches are:
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the Piglit mailing list