[Piglit] [PATCH] Create an initial to-do list

[Daniel Vetter]

On Thu, Sep 25, 2014 at 09:02:55AM -0600, Brian Paul wrote:
> I'm sure other people have items to add...
> ---
>  TODO |   28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 TODO
> 
> diff --git a/TODO b/TODO
> new file mode 100644
> index 0000000..fb5c405
> --- /dev/null
> +++ b/TODO
> @@ -0,0 +1,28 @@
> +
> +Piglit To-Do items
> +
> +
> +Port remaining Glean tests to Piglit (discard Glean tests which are
> +already covered by Piglit).
> +See https://bugs.freedesktop.org/show_bug.cgi?id=65676 for more details.
> +
> +
> +Move/rename tests in the bugs/ directory to proper places under tests/spec/
> +
> +
> +Replace calls such as assert(glGetError() == 0) with piglit_check_gl_error().

Just a quick aside: We've used coccinelle in our i-g-t testcase to great
effect for these kinds of replacements. Our current spatch is

http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/tree/lib/igt.cocci

Cheers, Daniel

> +
> +
> +Quite a few tests have GL enum names encoded in tables.  For example, in
> +tests/texturing/texture-rg.c:
> +
> +static const struct format_info IntFormats[] = {
> +   { "GL_R8", GL_R8, GL_RED, GL_FALSE, GL_FALSE, GL_FALSE },
> +   { "GL_R16", GL_R16, GL_RED, GL_FALSE, GL_FALSE, GL_FALSE },
> +   { "GL_RG8", GL_RG8, GL_RG, GL_FALSE, GL_FALSE, GL_FALSE },
> +[...]
> +
> +There's no reason to do this.  The program could use piglit_get_gl_enum_name()
> +instead to convert GL enums to string names.
> +
> +
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch