[Piglit] [PATCH 00/14] Add DSA tests for vertex array objects
Martin Peres
martin.peres at linux.intel.com
Wed Apr 1 00:03:40 PDT 2015
On 31/03/15 20:26, Fredrik Höglund wrote:
> This series adds piglit tests for the VAO portion of
> GL_ARB_direct_state_access.
>
> The tests are written so that they can be run against either the core
> or compatibility profiles. The exception is vao-core and vao-compatibility,
> which contain all the profile specific tests.
>
> Note that vao-attrib-format fails without this patch:
> http://patchwork.freedesktop.org/patch/44068
>
> It would be interesting to know if the tests pass with NVIDIA's
> implementation, but I haven't been able to test that.
I see the following warnings when compiling the patches:
Scanning dependencies of target arb_direct_state_access-vao-core
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-compat.c: In
function ‘piglit_init’:
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-compat.c:152:48:
warning: passing argument 6 of
‘piglit_dispatch_glVertexArrayVertexBuffers’ from incompatible pointer type
buffers, offsets, strides);
^
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-compat.c:152:48:
note: expected ‘const GLsizei *’ but argument is of type ‘const
GLsizeiptr *’
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-compat.c:181:48:
warning: passing argument 6 of
‘piglit_dispatch_glVertexArrayVertexBuffers’ from incompatible pointer type
buffers, offsets, strides);
^
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-compat.c:181:48:
note: expected ‘const GLsizei *’ but argument is of type ‘const
GLsizeiptr *’
[ 92%] Linking C executable
../../../../../bin/arb_direct_state_access-vao-compat-draw
[ 92%] Building C object
target_api/gl/tests/spec/arb_direct_state_access/CMakeFiles/arb_direct_state_access-vao-core.dir/vao-core.c.o
Scanning dependencies of target arb_direct_state_access-vao-create
Built target arb_direct_state_access-vao-attrib-format
Linking C executable
../../../../../bin/arb_direct_state_access-vao-binding-divisor
Scanning dependencies of target
arb_direct_state_access-vao-element-array-buffer
Scanning dependencies of target arb_direct_state_access-vao-get
Linking C executable ../../../../../bin/arb_direct_state_access-vao-compat
[ 92%] [ 92%] Built target arb_direct_state_access-vao-attrib-enabledisable
[ 92%] Building C object
target_api/gl/tests/spec/arb_direct_state_access/CMakeFiles/arb_direct_state_access-vao-create.dir/vao-create.c.o
Building C object
target_api/gl/tests/spec/arb_direct_state_access/CMakeFiles/arb_direct_state_access-vao-get.dir/vao-get.c.o
[ 92%] Scanning dependencies of target
arb_direct_state_access-vao-vertex-buffer
Building C object
target_api/gl/tests/spec/arb_direct_state_access/CMakeFiles/arb_direct_state_access-vao-element-array-buffer.dir/vao-element-array-buffer.c.o
[ 92%] /home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-core.c:
In function ‘piglit_init’:
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-core.c:148:48:
warning: passing argument 6 of
‘piglit_dispatch_glVertexArrayVertexBuffers’ from incompatible pointer type
buffers, offsets, strides);
^
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-core.c:148:48:
note: expected ‘const GLsizei *’ but argument is of type ‘const
GLsizeiptr *’
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-core.c:168:48:
warning: passing argument 6 of
‘piglit_dispatch_glVertexArrayVertexBuffers’ from incompatible pointer type
buffers, offsets, strides);
^
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-core.c:168:48:
note: expected ‘const GLsizei *’ but argument is of type ‘const
GLsizeiptr *’
Building C object
target_api/gl/tests/spec/arb_direct_state_access/CMakeFiles/arb_direct_state_access-vao-vertex-buffer.dir/vao-vertex-buffer.c.o
[ 92%] [ 92%] [ 92%] Built target arb_direct_state_access-vao-compat-draw
Built target arb_direct_state_access-vao-binding-divisor
[ 92%] Scanning dependencies of target
arb_direct_state_access-vao-vertex-buffers
[ 92%] Building C object
target_api/gl/tests/spec/arb_direct_state_access/CMakeFiles/arb_direct_state_access-vao-vertex-buffer.dir/dsa-utils.c.o
Building C object
target_api/gl/tests/spec/arb_direct_state_access/CMakeFiles/arb_direct_state_access-vao-core.dir/dsa-utils.c.o
Built target arb_direct_state_access-vao-compat
[ 92%] Building C object
target_api/gl/tests/spec/arb_direct_state_access/CMakeFiles/arb_direct_state_access-vao-vertex-buffers.dir/vao-vertex-buffers.c.o
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-get.c: In
function ‘test_getvertexarrayindexed64iv’:
/home/mupuf/piglit/tests/spec/arb_direct_state_access/vao-get.c:254:11:
warning: format ‘%lld’ expects argument of type ‘long long int’, but
argument 3 has type ‘GLint64’ [-Wformat=]
"was %lld, expected 128\n", param);
^
Linking C executable ../../../../../bin/arb_direct_state_access-vao-create
Here is the result of the run on nvidia 346.35: http://pastebin.com/TGPzKpPG
>
> Fredrik Höglund (14):
> dsa/utils: Add check_indexed_vao_param()
> dsa/utils: Add check_vbo_binding()
> arb_direct_state_access: Add a test for glCreateVertexArrays
> arb_direct_state_access: Add a test for glEnable/DisableVertexArrayAttrib
> arb_direct_state_access: Add a test for glVertexArrayAttrib[I|L]Format
> arb_direct_state_access: Add a test for glVertexArrayAttribBinding
> arb_direct_state_access: Add a test for glVertexArrayBindingDivisor
> arb_direct_state_access: Add a test for glVertexArrayElementBuffer
> arb_direct_state_access: Add a test for glVertexArrayVertexBuffer
> arb_direct_state_access: Add a test for glVertexArrayVertexBuffers
> arb_direct_state_access: Add a test for glGetVertexArray*iv
> arb_direct_state_access: Add a core-profile test
> arb_direct_state_access: Add a compatibility-profile test
> arb_direct_state_access: Add a compatibility-profile draw test
>
> tests/all.py | 12 +
> .../spec/arb_direct_state_access/CMakeLists.gl.txt | 12 +
> tests/spec/arb_direct_state_access/dsa-utils.c | 36 +
> tests/spec/arb_direct_state_access/dsa-utils.h | 15 +
> .../arb_direct_state_access/vao-attrib-binding.c | 132 ++++
> .../vao-attrib-enabledisable.c | 127 ++++
> .../arb_direct_state_access/vao-attrib-format.c | 791 +++++++++++++++++++++
> .../arb_direct_state_access/vao-binding-divisor.c | 119 ++++
> .../spec/arb_direct_state_access/vao-compat-draw.c | 171 +++++
> tests/spec/arb_direct_state_access/vao-compat.c | 199 ++++++
> tests/spec/arb_direct_state_access/vao-core.c | 186 +++++
> tests/spec/arb_direct_state_access/vao-create.c | 143 ++++
> .../vao-element-array-buffer.c | 123 ++++
> tests/spec/arb_direct_state_access/vao-get.c | 285 ++++++++
> .../arb_direct_state_access/vao-vertex-buffer.c | 140 ++++
> .../arb_direct_state_access/vao-vertex-buffers.c | 351 +++++++++
> 16 files changed, 2842 insertions(+)
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
More information about the Piglit
mailing list