[Piglit] [PATCH 04/15] arb_direct_state_access: Testing NamedBufferData.

Martin Peres martin.peres at linux.intel.com
Wed Apr 1 04:51:25 PDT 2015


On 23/01/15 21:03, Laura Ekstrand wrote:
> ---
>   tests/spec/arb_direct_state_access/namedbufferstorage.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_direct_state_access/namedbufferstorage.c b/tests/spec/arb_direct_state_access/namedbufferstorage.c
> index 2ddfab6..6630467 100644
> --- a/tests/spec/arb_direct_state_access/namedbufferstorage.c
> +++ b/tests/spec/arb_direct_state_access/namedbufferstorage.c
> @@ -217,8 +217,8 @@ read_subtest(GLboolean coherent, GLboolean client_storage)
>   
>   	glClear(GL_COLOR_BUFFER_BIT);
>   	glCreateBuffers(1, &srcbuf);
> +	glNamedBufferData(srcbuf, BUF_SIZE, array, GL_STATIC_DRAW);
>   	glBindBuffer(GL_COPY_READ_BUFFER, srcbuf);
> -	glBufferData(GL_COPY_READ_BUFFER, BUF_SIZE, array, GL_STATIC_DRAW);
>   
>   	/* Copy some data to the mapped buffer and check if the CPU can see it. */
>   	glBindBuffer(GL_COPY_WRITE_BUFFER, buffer);

While I see the point of having separate commits during the development 
of the mesa functionality, I fail to see the point of not having this 
squashed in the second patch.

Could you please squash this?


More information about the Piglit mailing list