[Piglit] [PATCH 01/15] arb_direct_state_access: Test for CreateFramebuffers.

[Martin Peres]

On 01/04/15 20:34, Anuj Phogat wrote:
> On Thu, Mar 5, 2015 at 6:01 PM, Laura Ekstrand <laura at jlekstrand.net> wrote:
>> ---
>>   .../arb_direct_state_access/create-framebuffers.c  | 76 ++++++++++++++++++++++
>>   1 file changed, 76 insertions(+)
>>   create mode 100644 tests/spec/arb_direct_state_access/create-framebuffers.c
>>
>> diff --git a/tests/spec/arb_direct_state_access/create-framebuffers.c b/tests/spec/arb_direct_state_access/create-framebuffers.c
>> new file mode 100644
>> index 0000000..97ba454
>> --- /dev/null
>> +++ b/tests/spec/arb_direct_state_access/create-framebuffers.c
>> @@ -0,0 +1,76 @@
>> +/*
>> + * Copyright 2015 Intel Corporation
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtaining a
>> + * copy of this software and associated documentation files (the "Software"),
>> + * to deal in the Software without restriction, including without limitation
>> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>> + * and/or sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice (including the next
>> + * paragraph) shall be included in all copies or substantial portions of the
>> + * Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
>> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> + * DEALINGS IN THE SOFTWARE.
>> + */
>> +
>> +/** @file create_framebuffers.c
> create-framebuffers.c
>> + *
>> + * Tests glCreateFramebuffers to see if it behaves in the expected way,
>> + * throwing the correct errors, etc.
>> + */
>> +
>> +#include "piglit-util-gl.h"
>> +#include "dsa-utils.h"
>> +
>> +PIGLIT_GL_TEST_CONFIG_BEGIN
>> +
>> +       config.supports_gl_core_version = 32;
>> +
>> +       config.window_visual = PIGLIT_GL_VISUAL_RGBA |
>> +               PIGLIT_GL_VISUAL_DOUBLE;
>> +
>> +PIGLIT_GL_TEST_CONFIG_END
>> +
>> +void
>> +piglit_init(int argc, char **argv)
>> +{
>> +       piglit_require_extension("GL_ARB_direct_state_access");
>> +}
>> +
>> +enum piglit_result
>> +piglit_display(void)
>> +{
>> +       bool pass = true;
>> +       GLuint name;
>> +
>> +       /* Throw some invalid inputs at glCreateFramebuffers. */
>> +
>> +       /* n is negative */
>> +       glCreateFramebuffers(-1, &name);
>> +       SUBTEST(GL_INVALID_VALUE, pass, "n < 0");
>> +
>> +       /* name is not a valid pointer */
>> +       glCreateFramebuffers(1, NULL);
>> +       SUBTEST(GL_NO_ERROR, pass, "framebuffers = NULL");
>> +
>> +
>> +       /* Check if it actually generates a real framebuffer object */
>> +
>> +       glCreateFramebuffers(1, &name);
>> +       pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
>> +       SUBTESTCONDITION((bool) glIsFramebuffer(name), pass,
>> +                        "IsFramebuffer()");
>> +
>> +       glDeleteFramebuffers(1, &name);
>> +
>> +       return pass ? PIGLIT_PASS : PIGLIT_FAIL;
>> +}
>> +
>> --
>> 2.1.0
> With above comment fixed:
> Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
With the above comment fixed + the inclusion in all.py:
Reviewed-by: Martin Peres <martin.peres at linux.intel.com>