[Piglit] [Bug 89884] New: [Bisected]Piglit run igt case fail
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri Apr 3 01:33:14 PDT 2015
https://bugs.freedesktop.org/show_bug.cgi?id=89884
Bug ID: 89884
Summary: [Bisected]Piglit run igt case fail
Product: piglit
Version: unspecified
Hardware: All
OS: Linux (All)
Status: NEW
Severity: major
Priority: high
Component: infrastructure
Assignee: baker.dylan.c at gmail.com
Reporter: huax.lu at intel.com
QA Contact: piglit at lists.freedesktop.org
System Environment:
--------------------------
Piglit: dfd8d8f9834326685b900aa41877d0359d8f26e9
==Bug detailed description==
-----------------------------
ConfigParser.NoSectionError: No section: 'igt'
Run igt case:
[root at x-hsw27 piglit]# ./piglit-run.py -t core_getclient tests/igt.py a
Traceback (most recent call last):
File "./piglit-run.py", line 32, in <module>
run(sys.argv[1:])
File "/GFX/Test/Piglit/piglit/framework/programs/run.py", line 286, in run
profile = framework.profile.merge_test_profiles(args.test_profile)
File "/GFX/Test/Piglit/piglit/framework/profile.py", line 456, in
merge_test_profiles
profile = load_test_profile(profiles.pop())
File "/GFX/Test/Piglit/piglit/framework/profile.py", line 434, in
load_test_profile
os.path.splitext(os.path.basename(filename))[0]))
File "/usr/lib64/python2.7/importlib/__init__.py", line 37, in import_module
__import__(name)
File "/GFX/Test/Piglit/piglit/tests/igt.py", line 78, in <module>
framework.core.PIGLIT_CONFIG.get('igt', 'path'), 'tests')
File "/usr/lib64/python2.7/ConfigParser.py", line 607, in get
raise NoSectionError(section)
ConfigParser.NoSectionError: No section: 'igt'
Bisect shows: dfd8d8f9834326685b900aa41877d0359d8f26e9 is the first bad commit
commit dfd8d8f9834326685b900aa41877d0359d8f26e9
Author: Dylan Baker <baker.dylan.c at gmail.com>
AuthorDate: Tue Mar 3 11:32:27 2015 -0800
Commit: Dylan Baker <baker.dylan.c at gmail.com>
CommitDate: Wed Apr 1 14:11:04 2015 -0700
profile.py: Don't allow accidental reassignments of TestDict keys
A common error in all.py is that two different tests are assigned to the
same key value in profile.test_list. This change prevents a key from
being reassigned to a new value on accident, but provides a mechanism to
allow reassignment, using a context manager. This allows tests like the
image_load_store tests in quick.py to be overwritten, but requires the
author to mark that they know that they are overwriting tests, and that
it's intentional.
The error message will compare the tests by command, if the two tests
have different commands then the commands will be printed for easy
visual comparison. This helps to identify whether a test is being added
twice (in a loop for example) or if two different tests are being
assigned the same name.
This also adds some tests for TestDict.
v2: - remove some rebase artifacts, this makes the code a little simpler
and a little cleaner
v3: - rebase on master, includes grouptools separator changes
v4: - Use a incremented value instead of True false for the context
manager, this allows the allow_reassignment contextmanager to be
nested. (Ilia)
v5: - Add comparison methods to the Test class
- Use said comparisons to make the error reporting more verbose
Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu> (v4)
==Reproduce steps==
----------------------------
1. ./piglit-run.py -t core_getclient tests/igt.py a
--
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150403/ce795b22/attachment.html>
More information about the Piglit
mailing list