[Piglit] [PATCH] arb_framebuffer_no_attachments: add params set&get test
imirkin at alum.mit.edu
Mon Apr 20 06:13:24 PDT 2015
On Mon, Apr 20, 2015 at 9:04 AM, Tapani <tapani.palli at intel.com> wrote:
> On 04/20/2015 03:58 PM, Ilia Mirkin wrote:
>> On Mon, Apr 20, 2015 at 4:16 AM, Tapani Pälli <tapani.palli at intel.com>
>>> All other tests except invalid_enum_check pass on Nvidia
>>> binary driver (version 346.35).
>>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>>> tests/all.py | 1 +
>>> .../CMakeLists.gl.txt | 1 +
>>> tests/spec/arb_framebuffer_no_attachments/params.c | 297
>>> 3 files changed, 299 insertions(+)
>>> create mode 100755 tests/spec/arb_framebuffer_no_attachments/params.c
>>> diff --git a/tests/all.py b/tests/all.py
>>> index 18124b7..018b37d 100755
>>> --- a/tests/all.py
>>> +++ b/tests/all.py
>>> @@ -2295,6 +2295,7 @@ with profile.group_manager(
>>> grouptools.join('spec', 'ARB_framebuffer_no_attachments')) as
>>> g(['arb_framebuffer_no_attachments-minmax'], run_concurrent=False)
>>> + g(['arb_framebuffer_no_attachments-params'], run_concurrent=False)
>> Why are both of these run_concurrent=False?
> Well ... just because of copy-paste. I'm not sure about the state of this
> field. Will someone go through all the tests in some point and change them
> concurrent or how is this supposed to work?
Each test has to be evaluated individually, so ideally you'd get it
right when you first add it. Either it does something funky that
requires no other tests to be running (e.g. futzing with global state,
timing, etc), or it doesn't. For the vast, vast, vast majority of
tests, it doesn't.
More information about the Piglit