[Piglit] [PATCH] DSA: fix error value for *TextureSubImage* when target doesn't match
Arthur Huillet
arthur.huillet at free.fr
Wed Apr 22 09:53:03 PDT 2015
Hi,
On 2015-04-22 18:37, Ilia Mirkin wrote:
> From the ARB_dsa spec:
>
> An INVALID_ENUM error is generated by *TexSubImage* if <target>
> does
> not match the command, as shown in table 8.subtarg.
>
> An INVALID_OPERATION error is generated by *TextureSubImage* if the
> effective target of <texture> does not match the command, as shown
> in
> table 8.subtarg.
>
> Probably the source of the confusion?
Yes, I believe this was the source of the confusion. At least it
confused *me* for a few minutes :) That's why I'm suggesting the policy
to always quote spec, so that reviewers and users can more easily spot
these problems.
> AFAIK a bunch of spec bugs were
> filed about these little inconsistencies... (But I don't know exactly
> what they were, no Khronos access for me.)
I haven't seen one. I haven't looked very hard.
Does the patch look OK to you?
--
Greetings,
A.H.
More information about the Piglit
mailing list