[Piglit] [PATCH 2/2] DSA: CreateTextures() with a NULL argument is allowed to crash
Fredrik Höglund
fredrik at kde.org
Fri Apr 24 08:13:13 PDT 2015
On Friday 24 April 2015, Arthur Huillet wrote:
> From: Arthur Huillet <ahuillet at nvidia.com>
>
> The pointer passed to CreateTextures() isn't required by the specification
> to be checked for validity, and the implementation is allowed to crash (as
> happens with NVIDIA's).
> Remove the bogus tests.
>
> Signed-off-by: Arthur Huillet <ahuillet at nvidia.com>
> ---
> tests/spec/arb_direct_state_access/create-textures.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/tests/spec/arb_direct_state_access/create-textures.c b/tests/spec/arb_direct_state_access/create-textures.c
> index a01be79..767cf41 100644
> --- a/tests/spec/arb_direct_state_access/create-textures.c
> +++ b/tests/spec/arb_direct_state_access/create-textures.c
> @@ -65,12 +65,6 @@ piglit_display(void)
> glCreateTextures(GL_TEXTURE_2D, -1, &name);
> pass &= piglit_check_gl_error(GL_INVALID_VALUE);
>
> - /* name is not a valid pointer */
> - glCreateTextures(GL_TEXTURE_2D, 1, 0);
> - pass &= piglit_check_gl_error(GL_NO_ERROR);
> - glCreateTextures(GL_TEXTURE_2D, 1, NULL);
> - pass &= piglit_check_gl_error(GL_NO_ERROR);
> -
> /* Trivial, but should work. */
> glCreateTextures(GL_TEXTURE_2D, 1, &name);
> pass &= piglit_check_gl_error(GL_NO_ERROR);
>
This patch is:
Reviewed-by: Fredrik Höglund <fredrik at kde.org>
More information about the Piglit
mailing list