[Piglit] [PATCH 00/14] Fixes for EGL and EGL tests

Chad Versace chad.versace at intel.com
Fri Apr 24 11:35:16 PDT 2015

On Mon 13 Apr 2015, Marek Olšák wrote:
> Hi everyone,
> These are mostly fixes that I took from Daniel Kurtz's github
> repository because I think they are good and he said he had no time to
> upstream them. I've been working on the fence extensions for
> Mesa/egl_dri2, so I've tested them all.

All the patches committed so far look good to me too.

("egl_khr_fence_sync: remove invalid_flag test" seems questionable, but
I trust that Daniel understands some nuance that I don't).

> The only patches which don't have Reviewed-by are the first one (which
> is mine and should be good to go) and the last two. I don't know if the
> last two are good/correct. Maybe somebody else knowing more about
> KHR_debug and the plans for the EGL dispatch can ACK them. If not,
> I will drop them.

As for the last two patches:

  - It's very close to being correct, but still has a fatal flaw.
    I'll respond to that patch directly.

  - I don't know enough about EGL_KHR_debug to comment on the last patch.

More information about the Piglit mailing list