[Piglit] [PATCH] arb_framebuffer_no_attachments: check GL_EXT_direct_state_access

Arthur Huillet arthur.huillet at free.fr
Wed Apr 29 05:17:19 PDT 2015


I'm not entirely following the first part, so get approval from somebody 
else, but for the second part:

Reviewed-by: Arthur Huillet <ahuillet at nvidia.com>
(And actually even Suggested-by :p)

Thanks!

On 2015-04-29 13:46, Tapani Pälli wrote:
> Check for GL_EXT_direct_state_access which was the original purpose
> of this subtest as there is interaction with it specified in the
> ARB_framebuffer_no_attachments spec and it has the expected error
> value behaviour of the test.
> 
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>  tests/spec/arb_framebuffer_no_attachments/params.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/spec/arb_framebuffer_no_attachments/params.c
> b/tests/spec/arb_framebuffer_no_attachments/params.c
> index 1792c6c..6677787 100644
> --- a/tests/spec/arb_framebuffer_no_attachments/params.c
> +++ b/tests/spec/arb_framebuffer_no_attachments/params.c
> @@ -179,7 +179,7 @@ dsa_subtest(GLuint fbo)
>  	GLint value;
>  	bool pass = true;
> 
> -	if (!piglit_is_extension_supported("GL_ARB_direct_state_access")) {
> +	if (!piglit_is_extension_supported("GL_EXT_direct_state_access")) {
>  		piglit_report_subtest_result(PIGLIT_SKIP, "dsa");
>  		return pass;
>  	}
> @@ -195,7 +195,7 @@ dsa_subtest(GLuint fbo)
>  		pass = pass && test_values(&tests[i], GL_FRAMEBUFFER, fbo);
>  	}
> 
> -	/* Test INVALID_VALUE error when fbo given does not exist. */
> +	/* Test using fbo name that was not returned by glGenFramebuffers. */
>  	if (!set_value(GL_FRAMEBUFFER_DEFAULT_WIDTH, 42, GL_FRAMEBUFFER,
>  		GL_INVALID_VALUE, 666))
>  		pass = false;

-- 
Greetings,
A.H.


More information about the Piglit mailing list