[Piglit] [PATCH] arb_direct_state_access: Add a FramebufferTextureLayer cube-map test

Ilia Mirkin imirkin at alum.mit.edu
Wed Apr 29 11:06:05 PDT 2015


Some trivia:

On Wed, Apr 29, 2015 at 1:41 PM, Fredrik Höglund <fredrik at kde.org> wrote:
> This test verifies that faces of a cube-map texture can be attached
> to a framebuffer object using glNamedFramebufferTextureLayer and
> glFramebufferTextureLayer.
> ---
>  tests/all.py                                       |   4 +
>  .../spec/arb_direct_state_access/CMakeLists.gl.txt |   1 +
>  .../fbo-texturelayer-cubemap.c                     | 322 +++++++++++++++++++++
>  3 files changed, 327 insertions(+)
>  create mode 100644 tests/spec/arb_direct_state_access/fbo-texturelayer-cubemap.c
>
> diff --git a/tests/all.py b/tests/all.py
> index 6197c18..e80c2cd 100755
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -4305,6 +4305,10 @@ with profile.group_manager(
>      g(['arb_direct_state_access-create-programpipelines'],
>        'create-programpipelines')
>      g(['arb_direct_state_access-create-queries'], 'create-queries')
> +    g(['arb_direct_state_access-fbo-texturelayer-cubemap glNamedFramebufferTextureLayer'],
> +      'fbo-texturelayer-cubemap glNamedFramebufferTextureLayer')
> +    g(['arb_direct_state_access-fbo-texturelayer-cubemap glFramebufferTextureLayer'],
> +      'fbo-texturelayer-cubemap glFramebufferTextureLayer')

oops? i don't think there's a binary called
'arb_direct_state_access-fbo-texturelayer-cubemap
glNamedFramebufferTextureLayer'...

[...]

> +void
> +piglit_init(int argc, char *argv[])
> +{
> +       GLuint program;
> +
> +       piglit_require_extension("GL_ARB_direct_state_access");
> +       piglit_require_extension("GL_ARB_draw_instanced");
> +       piglit_require_extension("GL_ARB_instanced_arrays");
> +       piglit_require_extension("GL_ARB_multi_bind");
> +       piglit_require_extension("GL_ARB_vertex_array_object");

Can you have a core context without VAO's?

> +       piglit_require_extension("GL_ARB_vertex_attrib_binding");
> +
> +       if (argc != 2)
> +               usage(argc, argv);
> +
> +       if (strcmp("glNamedFramebufferTextureLayer", argv[1]) == 0)
> +               test_named_fbo = true;
> +       else if (strcmp("glFramebufferTextureLayer", argv[1]) == 0)
> +               test_named_fbo = false;
> +       else
> +               usage(argc, argv);
> +
> +       program = piglit_build_simple_program(vs, fs);
> +
> +       glUseProgram(program);
> +}
> --
> 2.1.4
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list