[Piglit] [PATCH 2/3] copyteximage: do not run test under GL 1.0

Ian Romanick idr at freedesktop.org
Tue Aug 25 06:44:32 PDT 2015


On 08/24/2015 09:38 PM, Erik Faye-Lund wrote:
> glCopyTexImage{1,2}D was introduced in OpenGL 1.1, so there's no
> point in even running this test if we get an OpenGL 1.0 context.

Heh... The Linux OpenGL ABI requires at least 1.2, and I believe Windows
requires at least 1.1.  I think the lower layer uses 10 to indicate that
the old context creation method should be used.  I think if 11 or 12 is
specified and the implementation does not support GLX_ARB_create_context
(or similar), the test will fail to run.

That was the case at one time, anyway, and, IMO, that's a bug.  If the
version is less than 32, it should be able to use glXCreateContext and
check the version the old fashioned way after creation.

> Signed-off-by: Erik Faye-Lund <kusmabite at gmail.com>
> ---
>  tests/texturing/copyteximage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/texturing/copyteximage.c b/tests/texturing/copyteximage.c
> index 48b2263..e7e79c7 100644
> --- a/tests/texturing/copyteximage.c
> +++ b/tests/texturing/copyteximage.c
> @@ -111,7 +111,7 @@ static int test_target = -1;
>  
>  PIGLIT_GL_TEST_CONFIG_BEGIN
>  
> -	config.supports_gl_compat_version = 10;
> +	config.supports_gl_compat_version = 11;
>  
>  	config.window_width = IMAGE_SIZE*(ARRAY_SIZE(test_vectors)+1);
>  	config.window_height = IMAGE_SIZE;
> 



More information about the Piglit mailing list