[Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos

Matt Turner mattst88 at gmail.com
Wed Dec 2 13:17:30 PST 2015


On Wed, Dec 2, 2015 at 8:42 AM, Ian Romanick <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> Further discussion in Khronos has determined that UTF-8 in unused
> preprocessor defines as well.
>
> See Khronos internal bug #14939.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  .../glsl-es-3.00/compiler/utf8-unused-define.vert  | 26 +++++++++++++++++++++
>  .../glsl-es-3.00/compiler/utf8-used-define.vert    | 27 ++++++++++++++++++++++
>  2 files changed, 53 insertions(+)
>  create mode 100644 tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
>  create mode 100644 tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
>
> diff --git a/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert b/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
> new file mode 100644
> index 0000000..69cde74
> --- /dev/null
> +++ b/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
> @@ -0,0 +1,26 @@
> +#version 300 es
> +
> +/* [config]

I was surprised to see #version before the [config] block, but we do
seem to do that some other places (but basically only in ES tests...)

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the Piglit mailing list