[Piglit] [PATCH 1/3] tests/all.py: hide some pylint warnings that can't be (easily) fixed.

Vinson Lee vlee at freedesktop.org
Wed Dec 2 19:58:40 PST 2015


On Wed, Dec 2, 2015 at 2:36 PM,  <baker.dylan.c at gmail.com> wrote:
> From: Dylan Baker <baker.dylan.c at gmail.com>
>
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  tests/all.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tests/all.py b/tests/all.py
> index 9f1b4f3..03da7cd 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -20,6 +20,10 @@ __all__ = ['profile']
>  # doesn't trigger an error)
>  # pylint: disable=bad-continuation
>
> +# Shadowing variables is a bad practice. It's just nearly impossible with the
> +# format of this module to avoid it.
> +# pylint: disable=redefined-outer-name
> +
>
>  def add_single_param_test_set(adder, name, *params):
>      for param in params:
> @@ -201,7 +205,7 @@ def power_set(s):
>
>  ######
>  # Collecting all tests
> -profile = TestProfile()
> +profile = TestProfile()  # pylint: disable=invalid-name
>
>  # Find and add all shader tests.
>  for basedir in [TESTS_DIR, GENERATED_TESTS_DIR]:
> --
> 2.6.2
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit

Reviewed-by: Vinson Lee <vlee at freedesktop.org>


More information about the Piglit mailing list